diff options
| author | Pierre Moreau <dev@pmoreau.org> | 2018-04-17 18:13:15 +0200 |
|---|---|---|
| committer | Alexey Sotkin <alexey.sotkin@intel.com> | 2018-04-24 12:21:49 +0300 |
| commit | ba678a23baf4f8d33ac10258013b16acdc8d3c96 (patch) | |
| tree | 9fb08fd1358c0ddb3e6eeafe5603b71983e5fb7b /lib/SPIRV/Mangler/Mangler.cpp | |
| parent | 5fb8a94023aaa7fbd76dee0c2cf7cfb18d1d1558 (diff) | |
Run clang-tidy without the readability-identifier-naming enabled
Command used:
/usr/share/clang/run-clang-tidy.py -fix -format -header-filter "(./include/SPIRV.h|./lib/SPIRV/Mangler/FunctionDescriptor.h|./lib/SPIRV/Mangler/ManglingUtils.h|./lib/SPIRV/Mangler/NameMangleAPI.h|./lib/SPIRV/Mangler/ParameterType.h|./lib/SPIRV/Mangler/Refcount.h|./lib/SPIRV/libSPIRV/libSPIRV.h|./lib/SPIRV/libSPIRV/SPIRVBasicBlock.h|./lib/SPIRV/libSPIRV/SPIRVDebug.h|./lib/SPIRV/libSPIRV/SPIRVDecorate.h|./lib/SPIRV/libSPIRV/SPIRVEntry.h|./lib/SPIRV/libSPIRV/SPIRVEnum.h|./lib/SPIRV/libSPIRV/SPIRVError.h|./lib/SPIRV/libSPIRV/SPIRVErrorEnum.h|./lib/SPIRV/libSPIRV/SPIRVExtInst.h|./lib/SPIRV/libSPIRV/SPIRVFunction.h|./lib/SPIRV/libSPIRV/SPIRVInstruction.h|./lib/SPIRV/libSPIRV/SPIRVIsValidEnum.h|./lib/SPIRV/libSPIRV/SPIRVModule.h|./lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h|./lib/SPIRV/libSPIRV/SPIRVOpCode.h|./lib/SPIRV/libSPIRV/SPIRVOpCodeEnum.h|./lib/SPIRV/libSPIRV/SPIRVStream.h|./lib/SPIRV/libSPIRV/SPIRVType.h|./lib/SPIRV/libSPIRV/SPIRVUtil.h|./lib/SPIRV/libSPIRV/SPIRVValue.h|./lib/SPIRV/runtime/OpenCL/inc/spirv.h|./lib/SPIRV/runtime/OpenCL/inc/spirv_convert.h|./lib/SPIRV/OCLUtil.h|./lib/SPIRV/OCLTypeToSPIRV.h|./lib/SPIRV/SPIRVInternal.h|./lib/SPIRV/SPIRVMDBuilder.h|./lib/SPIRV/SPIRVMDWalker.h|./lib/SPIRV/SPIRVWriterPass.h)" -checks="-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters" `find . -iname "*.cpp"`
Manual edits:
* lib/SPIRV/libSPIRV/SPIRVStream.h: remove parentheses around `Type` on
line 178;
* lib/SPIRV/libSPIRV/SPIRVStream.cpp: remove parentheses around `Type`
on line 123
* lib/SPIRV/libSPIRV/SPIRVOpCodeEnum.h: remove added header guard
Diffstat (limited to 'lib/SPIRV/Mangler/Mangler.cpp')
| -rw-r--r-- | lib/SPIRV/Mangler/Mangler.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/SPIRV/Mangler/Mangler.cpp b/lib/SPIRV/Mangler/Mangler.cpp index b080477..91b99e6 100644 --- a/lib/SPIRV/Mangler/Mangler.cpp +++ b/lib/SPIRV/Mangler/Mangler.cpp @@ -95,8 +95,8 @@ public: // out of all enums it makes sense to substitute only // memory_scope/memory_order since only they appear several times in the // builtin declaration. - if (mangledPrimitive.compare("12memory_scope") == 0 || - mangledPrimitive.compare("12memory_order") == 0) { + if (mangledPrimitive == "12memory_scope" || + mangledPrimitive == "12memory_order") { if (!mangleSubstitution(t, mangledPrimitiveString(t->getPrimitive()))) { size_t index = m_stream.str().size(); m_stream << mangledPrimitiveString(t->getPrimitive()); |